Re: [PATCH] Remove po file charset stripping on Windows
Roman Donchenko wrote:
> Branko Cibej <brane_at_xbc.nu> писал в своём письме Sun, 13 Sep 2009 14:13:57
>> Roman Donchenko wrote:
>>> Meanwhile, I noticed that the Subversion libintl is specifically
>>> not to link to libiconv, which means it's not going to recode the
>>> whether bind_textdomain_codeset is called or not. Huh. I still suppose
>>> explicit call won't hurt.
>> I frankly don't understand the point of this discussion. Removing
>> codeset definition from the .po files is just an extra safety net that
>> prevents the aforementioned bug from raising its head if someone links
>> Subversion binaries with a different variant of libintl that does depend
>> on libiconv. The only downside I can think of is that it causes msgfmt
>> to complain during the build, but those warnings have no adverse side
> The point is that we can get rid of the warnings and simplify the build
> system by removing the stripping,
> while still providing the safety net by calling bind_textdomain_codeset().
I see. Assuming your change has no effect on how messages are displayed
on Windows, then I suppose it's a case of your bikeshed being lilac with
wisteria stripes, and mine the other way around. I just can't test that
assumption right now.
Received on 2009-09-14 07:07:43 CEST
This is an archived mail posted to the Subversion Dev