[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove po file charset stripping on Windows

From: Branko Cibej <brane_at_xbc.nu>
Date: Sun, 13 Sep 2009 12:13:57 +0200

Roman Donchenko wrote:
> Meanwhile, I noticed that the Subversion libintl is specifically modified
> not to link to libiconv, which means it's not going to recode the strings
> whether bind_textdomain_codeset is called or not. Huh. I still suppose an
> explicit call won't hurt.
>

The modification to libintl for Windows SVN is intentional. Because the
internal character encoding of APR on Windows is always UTF-8, as is the
source encoding of the .po files,
any kind of encoding conversion within libintl would be invalid and a
bug. Hence the removal of the libiconv dependency -- which, by the way,
is optional on Unix, but requires manual steps on Windows because of the
limitations of the build system.

I frankly don't understand the point of this discussion. Removing
codeset definition from the .po files is just an extra safety net that
prevents the aforementioned bug from raising its head if someone links
Subversion binaries with a different variant of libintl that does depend
on libiconv. The only downside I can think of is that it causes msgfmt
to complain during the build, but those warnings have no adverse side
effects.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2394211
Received on 2009-09-13 12:19:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.