On Fri, Sep 11, 2009 at 13:47, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_client/cat.c Fri Sep 11 10:47:53 2009 (r39249)
>...
> @@ -127,13 +122,25 @@ cat_local_file(svn_wc_context_t *wc_ctx,
> }
> else
> {
> - tm = entry->cmt_date;
> + SVN_ERR(svn_wc__node_get_changed_info(NULL, &tm, NULL, wc_ctx,
> + local_abspath, scratch_pool,
> + scratch_pool));
> }
>
> if (keywords)
> {
> + svn_revnum_t changed_rev;
> const char *rev_str;
> const char *author;
> + const svn_wc_entry_t *entry;
> +
> + SVN_ERR(svn_wc__get_entry_versioned(&entry, wc_ctx, local_abspath,
> + svn_node_unknown, FALSE, FALSE,
> + scratch_pool, scratch_pool));
This threw me off. I thought you needed the entry for something more,
or accidentally left this retrieval in. Rather... it is needed for
entry->url, much lower in the function. I would have suggested putting
this call right before the URL usage. (and I don't recall that we have
a NODE function for fetching the URL?)
>...
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393822
Received on 2009-09-12 11:04:56 CEST