[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39249 - in trunk/subversion: include/private libsvn_client libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 14 Sep 2009 17:00:32 -0500

On Sep 12, 2009, at 4:04 AM, Greg Stein wrote:

> On Fri, Sep 11, 2009 at 13:47, Hyrum K. Wright
> <hyrum_at_hyrumwright.org> wrote:
>> ...
>> +++ trunk/subversion/libsvn_client/cat.c Fri Sep 11 10:47:53
>> 2009 (r39249)
>> ...
>> @@ -127,13 +122,25 @@ cat_local_file(svn_wc_context_t *wc_ctx,
>> }
>> else
>> {
>> - tm = entry->cmt_date;
>> + SVN_ERR(svn_wc__node_get_changed_info(NULL, &tm, NULL, wc_ctx,
>> + local_abspath,
>> scratch_pool,
>> + scratch_pool));
>> }
>>
>> if (keywords)
>> {
>> + svn_revnum_t changed_rev;
>> const char *rev_str;
>> const char *author;
>> + const svn_wc_entry_t *entry;
>> +
>> + SVN_ERR(svn_wc__get_entry_versioned(&entry, wc_ctx,
>> local_abspath,
>> + svn_node_unknown, FALSE,
>> FALSE,
>> + scratch_pool,
>> scratch_pool));
>
> This threw me off. I thought you needed the entry for something more,
> or accidentally left this retrieval in. Rather... it is needed for
> entry->url, much lower in the function. I would have suggested putting
> this call right before the URL usage. (and I don't recall that we have
> a NODE function for fetching the URL?)

Added said API and used it in r39317.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2394801
Received on 2009-09-15 00:01:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.