Re: svn commit: r39246 - in trunk/subversion: include/private libsvn_wc

On Fri, Sep 11, 2009 at 11:55, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_wc/node.c   Fri Sep 11 08:55:14 2009        (r39246)
> @@ -176,6 +176,21 @@ svn_wc__node_get_kind(svn_node_kind_t *k
>  }
>
>  svn_error_t *
> +svn_wc__node_get_depth(svn_depth_t *depth,
> +                       svn_wc_context_t *wc_ctx,
> +                       const char *local_abspath,
> +                       apr_pool_t *scratch_pool)
> +{
> +  return svn_error_return(
> +    svn_wc__db_read_info(NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +                         NULL, NULL, NULL, depth, NULL, NULL, NULL,
> +                         NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +                         NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +                         wc_ctx->db, local_abspath, scratch_pool,
> +                         scratch_pool));
> +}

I don't think this is doing to work at all. Recall that a directory's
depth is recorded in the stub in the parent directory. The above logic
will retrieve the depth from the non-stub within the directory (ie.
name="")

(and if the directory is obstructed, then I dunno offhand what will happen)

I suspect that you're going to need a temp API, much like what I did
with the DELETED flag. See svn_wc__db_temp_dir_is_deleted()

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393821
Received on 2009-09-12 11:01:16 CEST