[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove po file charset stripping on Windows

From: Roman Donchenko <DXDragon_at_yandex.ru>
Date: Sat, 05 Sep 2009 23:37:15 +0400

Roman Donchenko <DXDragon_at_yandex.ru> писал в своём письме Thu, 27 Aug 2009
02:40:46 +0400:

> [[[
> On Windows, don't strip the charset from PO files - use
> bind_textdomain_codeset instead.
>
> * build/generator/build_locale.ezt: Remove the strip-po-charset.py
> invocation.
>
> * build/generator/gen_win.py:
> (POFile.__init__): don't store the .spo file name.
>
> * build/strip-po-charset.py: Remove.
>
> * subversion/libsvn_subr/nls.c:
> (svn_nls_init): Move the bind_textdomain_codeset invocation out of the
> #ifdef WIN32 block.
>
> * subversion/svn_private_config.hw: Indicate that bind_textdomain_codeset
> is supported.
> ]]]

Ping. This patch submission has received no comments (which is
understandable since it touches stuff written in 2004 in an attempt to get
rid of a few warnings, but the desire to DTRT makes me push it ;=]).

Meanwhile, I tested that the change, in fact, doesn't break the non-ASCII
characters in strings, by (temporarily) wrecking the German translation.
8=]

Cheers,
Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2391333
Received on 2009-09-05 21:38:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.