[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v4. line_transformer callback

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 27 Aug 2009 13:07:20 -0700

Stefan Sperling wrote:
> On Thu, Aug 27, 2009 at 01:00:18PM -0700, Blair Zajac wrote:
>>> It took me a second to see that line_transformer_cb is not a type
>>> but the variable name from the previous line. For long lines, we
>>> use something like this style:
>>>
>>> void
>>> svn_stream_set_line_transformer_callback
>>> (svn_stream_t *stream,
>>> svn_io_line_transformer_cb_t line_transformer_cb)
>> Oops, make that a two space indent:
>>
>> void
>> svn_stream_set_line_transformer_callback
>> (svn_stream_t *stream,
>> svn_io_line_transformer_cb_t line_transformer_cb)
>
> I thought because of no-space-before paren, this would read:
>
> void
> svn_stream_set_line_transformer_callback(
> svn_stream_t *stream,
> svn_io_line_transformer_cb_t line_transformer_cb)
>
> Or is this bike-sheddy?

It's bike-sheddy, but I'm following convention in the other header files. In
particular, look through subversion/include/svn_auth.h.

Blair

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388004
Received on 2009-08-27 22:07:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.