[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v4. line_transformer callback

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 27 Aug 2009 21:03:59 +0100

On Thu, Aug 27, 2009 at 01:00:18PM -0700, Blair Zajac wrote:
> >It took me a second to see that line_transformer_cb is not a type
> >but the variable name from the previous line. For long lines, we
> >use something like this style:
> >
> >void
> >svn_stream_set_line_transformer_callback
> > (svn_stream_t *stream,
> > svn_io_line_transformer_cb_t line_transformer_cb)
>
> Oops, make that a two space indent:
>
> void
> svn_stream_set_line_transformer_callback
> (svn_stream_t *stream,
> svn_io_line_transformer_cb_t line_transformer_cb)

I thought because of no-space-before paren, this would read:

void
svn_stream_set_line_transformer_callback(
  svn_stream_t *stream,
  svn_io_line_transformer_cb_t line_transformer_cb)

Or is this bike-sheddy?

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388003
Received on 2009-08-27 22:05:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.