[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v4. line_transformer callback

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 27 Aug 2009 21:22:10 +0100

On Thu, Aug 27, 2009 at 08:49:21PM +0100, Stefan Sperling wrote:
> }
> while (filtered);
> svn_pool_destroy(iterpool);
>
> if (stream->line_transformer_cb)
> SVN_ERR(line_transformer(stream, stringbuf, str->data, pool));
> else
> *stringbuf = svn_stringbuf_dup(str, pool);
>
> return SVN_NO_ERROR;

My change doesn't work, because str is allocated in iterpool :-/

The former order of things thus makes sense, but I'll put a huge
fat comment there for the next person to stumble over this.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388008
Received on 2009-08-27 22:23:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.