Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

Hi Greg,

On 23.08.09 17:13, Greg Stein wrote:
> Hey Martin,
>
> I've always applied a line length of 78. A character in the 79th
> position can cause Emacs (in certain setups) to display a line
> continuation character in position 80, and then nothing on the next
> line. Annoying. But trimming columns to 78 keeps within the "80"
> column limit.

Oh, I thought it was 72. 78 is nice, then there will be less formatting
changes.

> I would suggest files other than log.[ch] -- the loggy subsystem is
> going to be completely removed over the next six weeks.

Ouch, another wasted hour ;-)

> Some of the adm_* files could be a good place to start.

ok, I will consider the log code as a learning session and move on to the adm
files :-)

> And yes: multiple smaller patches is much better than a mother patch.
> You'll be able to get feedback as you go, and start to learn more
> about style and clarification of the goals, rather than waiting until
> "the end" for that info. You'll also be racing time as we make other
> changes to the code, and you'll have a hard time finding somebody
> wanting to review 2000 lines of pool alterations :-)

Yep, exactly what I thought.. :-)

> Cheers,
> -g

-- 
Martin
Subcommander 2.0.0 Beta 4 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386528