[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 23 Aug 2009 11:27:45 -0400

On Sun, Aug 23, 2009 at 11:21, Neels Janosch Hofmeyr<neels_at_elego.de> wrote:
>...
> Martin, just a quick rant: if you do cosmetic changes, it's nice to
> - not mix cosmetic changes with functional changes in a patch, and

There is a balance to this, I think. A cosmetic change here or there
in a functional patch is okay, I think. Just not widespread changes
along with functional changes.

> - group a whole bunch of cosmetic changes in a single patch.

I think this is totally fine. As long as *no* functional changes
occur, then I see no problem with a whole ton of disparate cosmetic
changes.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386521
Received on 2009-08-23 17:28:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.