[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 23 Aug 2009 11:13:55 -0400

Hey Martin,

I've always applied a line length of 78. A character in the 79th
position can cause Emacs (in certain setups) to display a line
continuation character in position 80, and then nothing on the next
line. Annoying. But trimming columns to 78 keeps within the "80"
column limit.

If you're going to make *many* line-length reflow changes (ie. just
formatting rather than functional), then we tend to make those
separate revisions from functional ones. It is a subjective matter, as
doing a few formatting updates along with a functional change is fine.
Obviously, if your functional change requires reflowing, then that's
totally cool.

I would suggest files other than log.[ch] -- the loggy subsystem is
going to be completely removed over the next six weeks.

Some of the adm_* files could be a good place to start.

And yes: multiple smaller patches is much better than a mother patch.
You'll be able to get feedback as you go, and start to learn more
about style and clarification of the goals, rather than waiting until
"the end" for that info. You'll also be racing time as we make other
changes to the code, and you'll have a hard time finding somebody
wanting to review 2000 lines of pool alterations :-)


On Sun, Aug 23, 2009 at 09:55, Martin Hauner<martin.hauner_at_gmx.net> wrote:
> Hi,
> At first I started to create a single large patch. But I think going with
> several smaller patches and doing this step by step is a safer route. It will be
> a lot easier to review and reduces the risk of introducing any errors.
> I will try to do this starting with the lower level functions, starting with
> log.h/log.c.
> Is this ok?
> I also wonder if I should modify the formatting where the lines get longer
> than 72 characters. There are a lot of other lines that don't strictly follow
> the line limit?
> --
> Martin
> Subcommander 2.0.0 Beta 4 - http://subcommander.tigris.org
> a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386500

Received on 2009-08-23 17:14:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.