[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

From: Neels Janosch Hofmeyr <neels_at_elego.de>
Date: Sun, 23 Aug 2009 17:21:35 +0200

Martin Hauner wrote:
> I also wonder if I should modify the formatting where the lines get longer
> than 72 characters. There are a lot of other lines that don't strictly follow

Quoting HACKING:
[[[
Restrict lines to 79 columns, so that code will display well in a minimal
standard display window. (There can be exceptions, such as when declaring a
block of 80-column text with a few extra columns taken up by indentation,
quotes, etc., if splitting each line in two would be unreasonably messy.)
]]]

IMHO 76 is nicer, so code can still be indented without redoing the
wrapping. It's not a showstopper, really, if a line gets longer, but it's
nice to adhere to the limit nevertheless.

Martin, just a quick rant: if you do cosmetic changes, it's nice to
- not mix cosmetic changes with functional changes in a patch, and
- group a whole bunch of cosmetic changes in a single patch.

Anyway, if you don't have commit access, I guess it's fine to not bother too
much about cosmetic fixes.

~Neels

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386519

Received on 2009-08-23 17:24:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.