On Fri, May 29, 2009 at 3:07 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Paul T. Burba wrote:
>> Author: pburba
>> Date: Fri May 29 11:59:01 2009
>> New Revision: 37894
>
> [...]
>
>> Â Â Â Â /* Hmmm. Â Ideally, we would append to a native-encoding buf
>> Â Â Â Â Â before starting iteration, then convert back to UTF-8 for
>> Â Â Â Â Â return. But I suppose that would make the appending code
>> Â Â Â Â Â sensitive to i18n in a way it shouldn't be... Oh well. */
>> - Â Â Â /* ### could alloc in scratch, then copy to result in baton... */
>> - Â Â Â SVN_ERR(cstring_from_utf8(&unique_name_apr, unique_name, result_pool));
>> + Â Â Â SVN_ERR(cstring_from_utf8(&unique_name_apr, unique_name, scratch_pool));
>
> Do we also need need to dup unique_name_apr to result_pool when we set
> baton->name ?
It certainly appears that we do, fixed r37896.
Thanks,
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2356934
Received on 2009-05-29 21:24:58 CEST