[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37894 - trunk/subversion/libsvn_subr

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 29 May 2009 15:07:49 -0400

Paul T. Burba wrote:
> Author: pburba
> Date: Fri May 29 11:59:01 2009
> New Revision: 37894

[...]

> /* Hmmm. Ideally, we would append to a native-encoding buf
> before starting iteration, then convert back to UTF-8 for
> return. But I suppose that would make the appending code
> sensitive to i18n in a way it shouldn't be... Oh well. */
> - /* ### could alloc in scratch, then copy to result in baton... */
> - SVN_ERR(cstring_from_utf8(&unique_name_apr, unique_name, result_pool));
> + SVN_ERR(cstring_from_utf8(&unique_name_apr, unique_name, scratch_pool));

Do we also need need to dup unique_name_apr to result_pool when we set
baton->name ?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2356919

Received on 2009-05-29 21:08:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.