Woah!!!
For stupid reasons, I missed the compilation failures in this change.
Sigh. But the tests passed! :-P
Fix coming up in just a second (after running a few tests on the
*real* change..)
Thanks,
-g
On Fri, Apr 24, 2009 at 10:24, Senthil Kumaran S <senthil_at_collab.net> wrote:
> Greg Stein wrote:
>> Author: gstein
>> Date: Thu Apr 23 16:53:42 2009
>> New Revision: 37453
>>
>> Log:
>> Rejigger and simplify some code in complete_directory(), based on some
>> recent changes.
>>
>> * subversion/libsvn_wc/update_editor.c:
>> (complete_directory): constify ENTRY since we don't try to modify it any
>> more (yay!). remove the 'if (... *eb->target)' block since that
>> condition is already satisfied by an outer conditional. use
>> svn_wc_entry rather than reading the entries hash.
>> + full_target = svn_dirent_join(eb->anchor, eb->target, pool);
>> +
>> + SVN_ERR(svn_wc_adm_retrieve(&adm_access, eb->adm_access, path, pool));
>> + SVN_ERR(svn_wc_entry(&entry, adm_access, TRUE, pool));
>
> Here, svn_wc_entry takes 5 arguments, but only 4 are provided.
>
> <snip>
> svn_error_t *
> svn_wc_entry(const svn_wc_entry_t **entry,
> const char *path,
> svn_wc_adm_access_t *adm_access,
> svn_boolean_t show_hidden,
> apr_pool_t *pool);
> </snip>
>
> --
> Senthil Kumaran S
> http://www.stylesen.org/
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1888228
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1888620
Received on 2009-04-24 11:05:25 CEST