[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37453 - trunk/subversion/libsvn_wc

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Fri, 24 Apr 2009 13:54:21 +0530

Greg Stein wrote:
> Author: gstein
> Date: Thu Apr 23 16:53:42 2009
> New Revision: 37453
>
> Log:
> Rejigger and simplify some code in complete_directory(), based on some
> recent changes.
>
> * subversion/libsvn_wc/update_editor.c:
> (complete_directory): constify ENTRY since we don't try to modify it any
> more (yay!). remove the 'if (... *eb->target)' block since that
> condition is already satisfied by an outer conditional. use
> svn_wc_entry rather than reading the entries hash.
> + full_target = svn_dirent_join(eb->anchor, eb->target, pool);
> +
> + SVN_ERR(svn_wc_adm_retrieve(&adm_access, eb->adm_access, path, pool));
> + SVN_ERR(svn_wc_entry(&entry, adm_access, TRUE, pool));

Here, svn_wc_entry takes 5 arguments, but only 4 are provided.

<snip>
svn_error_t *
svn_wc_entry(const svn_wc_entry_t **entry,
             const char *path,
             svn_wc_adm_access_t *adm_access,
             svn_boolean_t show_hidden,
             apr_pool_t *pool);
</snip>

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1888228
Received on 2009-04-24 10:24:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.