[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixed typo in message comment

From: Edmund Wong <ed_at_kdtc.net>
Date: Sat, 18 Apr 2009 10:02:10 +0800

Greg Stein wrote:
>
> In the future, I'd ask that you not indent these. If I copy/paste the
> above, then I'll have to dedent it.

My bad. I'll keep that in mind.

>
>> PS: I know the e-mail is not the same as this one. I've got
>
> *shrug* ... I'm not sure anybody is worried about it. Don't be concerned.
>
>> ...
>> +++ subversion/libsvn_ra_local/ra_plugin.c (working copy)
>> @@ -451,7 +451,7 @@
>> &fs_path,
>> repos_URL,
>> session->pool),
>> - _("Unable to open an ra_local session to URL"));
>> + _("Unable to open a ra_local session to URL"));
>> sess->fs_path = svn_stringbuf_create(fs_path, session->pool);
>
> I would disagree with this change.
>
> If I spoke the line, I would say "... open an ARE AY local session
> ...". Saying the letters implies "an" rather than "a". The latter
> would only make sense if you said "RAH local", which nobody does :-P

Oh. That's why. What about " an @c svn_wc_..."? From the
same logic, it'd be "an @c ESS-VEE-EN..." right? NM about this
patch.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1779466
Received on 2009-04-18 04:03:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.