Re: [PATCH] Fixed typo in message comment

On Fri, Apr 17, 2009 at 11:08, Edmund Wong <ed_at_kdtc.net> wrote:
> Hi,
>
> A quick "nitpick" patch, if I may?
>
> Log:
>
> [[[
>    Fix typo in error message.
>
>    * subversion/libsvn_ra_local/ra_plugin.c
>      (svn_ra_local__open): s/an/a/
>
>    Patch by: Edmund Wong <edmund {at} belfordhk.com
>
> ]]]

In the future, I'd ask that you not indent these. If I copy/paste the
above, then I'll have to dedent it.

> PS: I know the e-mail is not the same as this one.  I've got

*shrug* ... I'm not sure anybody is worried about it. Don't be concerned.

>...
> +++ subversion/libsvn_ra_local/ra_plugin.c      (working copy)
> @@ -451,7 +451,7 @@
>                                     &fs_path,
>                                     repos_URL,
>                                     session->pool),
> -            _("Unable to open an ra_local session to URL"));
> +            _("Unable to open a ra_local session to URL"));
>   sess->fs_path = svn_stringbuf_create(fs_path, session->pool);

I would disagree with this change.

If I spoke the line, I would say "... open an ARE AY local session
...". Saying the letters implies "an" rather than "a". The latter
would only make sense if you said "RAH local", which nobody does :-P

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1765616
Received on 2009-04-17 12:54:03 CEST