[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: patch_tests.py 4 on Windows

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Fri, 17 Apr 2009 23:58:46 +0200

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: vrijdag 17 april 2009 23:50
> To: Paul Burba
> Cc: dev_at_subversion.tigris.org
> Subject: Re: patch_tests.py 4 on Windows
>
> On Fri, Apr 17, 2009 at 04:52:43PM -0400, Paul Burba wrote:
> > CCing dev, which I meant to do from the start
> >
> > On Fri, Apr 17, 2009 at 4:20 PM, Paul Burba <ptburba_at_gmail.com>
> wrote:
> > > That can be fixed with this simple patch:
>
> Thanks, I'll apply that.
>
> > > Then the test gets a bit further before failing:
>
> > > The problem here is that
> > > patch.c:resolve_target_path(target_path='/A/B/lambda') calls
> > > svn_dirent_is_absolute(target_path='/A/B/lambda') but
> > > target_path='/A/B/lambda' *DOES NOT* consider
> > > 'target_path='/A/B/lambda' absolute for reasons I don't completely
> > > follow (see r36310 which made this change).
>
> Hmm. This is bad.
> Maybe Bert has an idea about what we can do here?

On Windows '/dir' is relative to the current disk. So if your current
directory is F:/projects, the absolute path of '/dir' is 'F:/dir'. But if my
cwd is 'C:/Windows', '/dir' becomes 'C:/dir'.

As '/dir' can have multiple absolute formats '/dir' can't be absolute on
Windows.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1775738
Received on 2009-04-17 23:59:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.