Re: svn commit: r37278 - trunk/subversion/libsvn_client

On Fri, Apr 17, 2009 at 10:39:41PM +0100, Stefan Sperling wrote:
> > > +/* ### forward-declaration */
> > > +static svn_error_t *
> > > +apply_textdiffs(const char *patch_path, svn_client_ctx_t *ctx,
> > > +                apr_pool_t *pool);
> >
> > Will this go away at some point? And could you put this at the TOP of
> > the file, rather than hidden in the middle of the code?
>
> It can only go away if we move the svn_client_patch() function to
> the end of the file.
>
> Right now, it's nice to have the svn-protocol-specific stuff at
> the top, and the unidiff-specific stuff at the bottom.
>
> I expect the svn-protocol-specific stuff to be changed a lot at some
> point, when we clean it up then.

Should have said "we can clean it up then".

Stefan
Received on 2009-04-17 23:59:06 CEST