Hi Lars,
Firstly, please don't take anything in my comments personally.
I am a little new to the role of Patch Manager (PM) here at the SVN
project - so it could well be a case of;
"I" need to learn something from this exchange.
None the less - my reply is amongst your post.
On 15/04/2009, at 6:01 PM, Lars Gullik Bjønnes wrote:
> Gavin Baumanis <gavinb_at_thespidernet.com> writes:
>
> | Hi Lars,
>>
> | Whether *everyone* agrees or not is almost irrelevant.
>>
> | It's always advisable to follow;
> | http://subversion.tigris.org/hacking.html#patches
> | when submitting any patch.
>>
> | As the patch submitter - you're in the best place to do this work,
> | because you inherently know the intent of the patch you propose.
>>
> | If you need assistance (with the code or with following the patch
> | submission guidelines), don't be shy to ask.
> | Most on the list, are almost to a fault, generous with their time
> for
> | mentoring.
>
> This was not really a patch submission at all, but more of a request
> for
> interest.
While technically you may well be right you did originally state;
>> This is a rather dirty patch (mailer.py did not lend itself to
>> modifications too nicely) that adds some more config vars to the conf
>> file:
So, "This is rather a dirty patch".
Means something other than this is a patch?
Albeit one that is incomplete, may well require some comments /
further work?
And the advice to follow the patch submission rules, and to ask for
help if needed was directed at how your ended your original email;
>> If there are interest in cleaning this up for inclusion in subversion
>> I'll update against current trunk and try to clean it up further. As
>> it is now it is mostly FYI only.
My point being, that you're much more likely to receive comments about
a patch submission if it is already in the "expected" format / style.
And, if you needed help updating your ideas to a "real" patch
submission - then you should feel at ease with asking for help.
If you were to weight your work on wether or not your email received
any comments - then you could well be waiting for a long time.
A properly formatted submission is far more likely to be provided some
attention, over one than that isn't - time being a rather expensive /
valued commodity and the project being staffed by volunteers and all
that...
>
>
> If anyone (not everyone) is interested in seeing this functionality in
> mailer.py, then I'll work to make that happen with nice patches that
> follow every regulation you might have, but until then I won't bother.
>
> (You didn't just send me your pre-canned response to these kind of
> messages did you, without reading the message?)
I don't do canned responses.
While the job of PM here in the subversion project is pretty light
work really, a part of that role is to see all patch submissions
through to fruition.
Whether that end be; Successful commit into the project or the patch
is rejected due to an appropriate reason or the patch gets filed away
into the issue tracker so that it (the submission) isn't a totally
wasted effort.
And to that, I have done and will continue to offer the advice that
all patch submissions should be in the appropriate format, should have
an appropriate log message and if you need any help, just ask. After
all, the mailing list and it's contributors are here to help you.
Regardless, of the intent of your email (they way you meant for it to
be handled), as opposed to how it was - the advice is sound.
Finally, since your original email wasn't really a patch submission -
I suppose it's all really a mute point.
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1725373
Received on 2009-04-15 12:53:03 CEST