Gavin Baumanis <gavinb_at_thespidernet.com> writes:
| Hi Lars,
>
| Firstly, please don't take anything in my comments personally.
That would be hard as you don't know me and I don't know you.
| I am a little new to the role of Patch Manager (PM) here at the SVN
| project - so it could well be a case of;
| "I" need to learn something from this exchange.
| None the less - my reply is amongst your post.
>
| On 15/04/2009, at 6:01 PM, Lars Gullik Bjønnes wrote:
>
>> Gavin Baumanis <gavinb_at_thespidernet.com> writes:
>>
>> | Hi Lars,
>>>
>> | Whether *everyone* agrees or not is almost irrelevant.
>>>
>> | It's always advisable to follow;
>> | http://subversion.tigris.org/hacking.html#patches
>> | when submitting any patch.
>>>
>> | As the patch submitter - you're in the best place to do this work,
>> | because you inherently know the intent of the patch you propose.
>>>
>> | If you need assistance (with the code or with following the patch
>> | submission guidelines), don't be shy to ask.
>> | Most on the list, are almost to a fault, generous with their time
>> for
>> | mentoring.
>>
>> This was not really a patch submission at all, but more of a request
>> for
>> interest.
>
| While technically you may well be right you did originally state;
>
>>> This is a rather dirty patch (mailer.py did not lend itself to
>>> modifications too nicely) that adds some more config vars to the conf
>>> file:
I see that I could have organized my message a bit better. Just
ordering would have helped heaps I guess.
| So, "This is rather a dirty patch".
| Means something other than this is a patch?
| Albeit one that is incomplete, may well require some comments /
| further work?
Means that this are how the features are currenctly
implemented, usable but not for applyinng. And the reason why it is
"rather a dirty patch" is because of the layer violations required by
the current inheritence tree (to many is-a relationships when has-a
would seem more proper.)
Also I wanted to show the patch just to show that my wanted changes
was not just fluff.
| And the advice to follow the patch submission rules, and to ask for
| help if needed was directed at how your ended your original email;
I do not really need any help in getting this kind of features into
mailer.py, but to do it in a (FMPOV) nice way can be a challenge and
require some discussion. (I am faily good with oo, but not
neccessarily in the context of python.)
>>> If there are interest in cleaning this up for inclusion in subversion
>>> I'll update against current trunk and try to clean it up further. As
>>> it is now it is mostly FYI only.
>
| My point being, that you're much more likely to receive comments about
| a patch submission if it is already in the "expected" format / style.
| And, if you needed help updating your ideas to a "real" patch
| submission - then you should feel at ease with asking for help.
| If you were to weight your work on wether or not your email received
| any comments - then you could well be waiting for a long time.
I was mainly fishing for comments like: "Such a feature would be nice
to have in mailer.py, please make a formal submission."
| A properly formatted submission is far more likely to be provided some
| attention, over one than that isn't - time being a rather expensive /
| valued commodity and the project being staffed by volunteers and all
| that...
And really... how far was my message really from a properly formatted
submission? (Properly formatted does not mean that the message is sound).
>> If anyone (not everyone) is interested in seeing this functionality in
>> mailer.py, then I'll work to make that happen with nice patches that
>> follow every regulation you might have, but until then I won't bother.
>>
>> (You didn't just send me your pre-canned response to these kind of
>> messages did you, without reading the message?)
>
| I don't do canned responses.
I guess it was the "*everyone*" that make me both think about
pre-canned and that you did not actally read the whole message.
At least I have gotten one positive response, so I'll invest some more
time on this feature(s).
--
Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1726478
Received on 2009-04-15 15:21:27 CEST