[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Completed TODO: svn_stream_copy3()

From: Edmund Wong <ed_at_kdtc.net>
Date: Sat, 11 Apr 2009 23:03:15 +0800

Stefan Sperling wrote:
>
> You don't need the extra parens around err, in my opinion.
>
> if (err || (len != SVN__STREAM_CHUNK_SIZE))
> is fine.
>
> I'll leave the rest of the review to Greg :)

It does look better without the extra parens. I'll
wait for Greg's review before I output the patch.

Thanks.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1650687
Received on 2009-04-11 17:04:17 CEST

This message: [ Message body ]
Next message: Mark Phippard: "Re: buddy for two externals issues? -- was: Re: locking externals"
Previous message: Edmund Wong: "Re: [PATCH] Completed TODO: svn_stream_copy3()"
In reply to: Stefan Sperling: "Re: [PATCH] Completed TODO: svn_stream_copy3()"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.