[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Completed TODO: svn_stream_copy3()

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 10 Apr 2009 18:03:08 +0100

On Sat, Apr 11, 2009 at 12:06:11AM +0800, Edmund Wong wrote:
> Hi again,
>
> Here's another attempt at this patch. I took the
> liberty of doing the following:
>
> if ((err) || (len != SVN__STREAM_CHUNK_SIZE))
> break;

You don't need the extra parens around err, in my opinion.

    if (err || (len != SVN__STREAM_CHUNK_SIZE))
is fine.

I'll leave the rest of the review to Greg :)

Stefan
Received on 2009-04-10 19:03:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.