Re: [PATCH] Completed TODO: svn_stream_copy3()

Daniel Shahaf wrote:
>> Is this allowed?
>>
>> if (err = cancel_func(cancel_baton))
>> break;
>>
>
> It's wrong, because cancel_func may be NULL.

Good point.

>
> If I were you, I'd try to keep the logic changes minimal --- i.e., avoid
> reordering the various checks on LEN and CANCEL_FUNC. They work well as
> they are, so no reason to change them. (If you change something, you have
> to think whether the change is correct...)
>

Understood. I'll keep that in mind when I do any
changes.

Thanks.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1650606
Received on 2009-04-11 17:02:16 CEST