On Wed, Feb 18, 2009 at 3:10 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> On Wed, Feb 18, 2009 at 10:57 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>> On Wed, Feb 18, 2009 at 10:22 PM, Paul Burba <ptburba_at_gmail.com> wrote:
<snip>
>>> Ivan,
>>>
>>> This is supposed to *build* sqlite if I point --with-sqlite to a
>>> directory containing the amalgamation files right? Because no matter
>>> where I put the amalgamation the build fails for me because
>>> sqlite3.lib is not created:
>>>
>>> (If this is working for you I suspect you are picking up some existing
>>> sqlite.lib)
>> Oops, my fault. I post updated patch in ten minutes.
>>
> Here is updated patch.
>
> --
> Ivan Zhakov
Ivan,
I checked the following scenarios, everything works fine:
--with-sqlite | TARGET | .\sqlite-amalgamation | Result
gen-make.py OPTION | | |
============================================================================
--with-sqlite TARGET | sqlite3.h | Empty | Build
| sqlite3.c | | Successful
============================================================================
--with-sqlite TARGET | VS2008 sqlite | Empty | Build
| solution with | | Successful
| .\bin | |
| .\src | |
| .\lib | |
| setup | |
============================================================================
None | Empty | VS2007 sqlite | Build
| | solution | Successful
| | with |
| | .\bin |
| | .\src |
| | .\lib |
| | setup |
============================================================================
None | Empty | sqlite3.h | Build
| | sqlite3.c | Successful
============================================================================
None | Empty | Empty | SQLite not
| | | found
| | | error.
============================================================================
The only other thing we might want to add is to stop the build if we
detect sqlite < 3.4.0, rather than simply issuing a warning; the
attached variant of your patch does that.
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1188411
Received on 2009-02-18 23:26:02 CET