[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35164 - trunk/subversion/libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Mon, 12 Jan 2009 14:09:31 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Greg,

Greg Stein wrote:
> That is the wrong fix. You should be adding "const" to
> svn_checksum_size... NOT dropping it from this function. This function
> doesn't change the checksum, nor does the size computation, so they
> *should* be const.

Reverted r35164 in r35165. I ve attached the patch based on your comments
above. If this is good, then I can go ahead and commit it.

[[[
Follow up r35156.

Suppress warning of "argument 1 of 'svn_checksum_size' discards qualifiers
from pointer target type".

* subversion/libsvn_subr/checksum.c
  (svn_checksum_size): Accept 'const svn_checksum_t'.

* subversion/include/svn_checksum.h
  (svn_checksum_size): Reflect above change.

Suggested by: gstein
]]]

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJawHC9o1G+2zNQDgRAqakAJwPMuxJ+9cOXRCumGBVg4HQj8cL2QCfR1kk
3uErBKtypOrh3kdaKMHfPbI=
=PaY+
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1018593

Received on 2009-01-12 09:39:52 CET

This is an archived mail posted to the Subversion Dev mailing list.