Re: svn commit: r35164 - trunk/subversion/libsvn_subr
Looks great. Thanks!!
On Mon, Jan 12, 2009 at 00:39, Senthil Kumaran S <senthil_at_collab.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Hi Greg,
> Greg Stein wrote:
>> That is the wrong fix. You should be adding "const" to
>> svn_checksum_size... NOT dropping it from this function. This function
>> doesn't change the checksum, nor does the size computation, so they
>> *should* be const.
> Reverted r35164 in r35165. I ve attached the patch based on your comments
> above. If this is good, then I can go ahead and commit it.
> Follow up r35156.
> Suppress warning of "argument 1 of 'svn_checksum_size' discards qualifiers
> from pointer target type".
> * subversion/libsvn_subr/checksum.c
> (svn_checksum_size): Accept 'const svn_checksum_t'.
> * subversion/include/svn_checksum.h
> (svn_checksum_size): Reflect above change.
> Suggested by: gstein
> Thank You.
> - --
> Senthil Kumaran S
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> -----END PGP SIGNATURE-----
Received on 2009-01-12 09:41:29 CET
This is an archived mail posted to the Subversion Dev