[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35164 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 12 Jan 2009 00:04:53 -0800

That is the wrong fix. You should be adding "const" to
svn_checksum_size... NOT dropping it from this function. This function
doesn't change the checksum, nor does the size computation, so they
*should* be const.

On Sun, Jan 11, 2009 at 23:08, Senthil Kumaran S <senthil_at_collab.net> wrote:
> Author: stylesen
> Date: Sun Jan 11 23:08:48 2009
> New Revision: 35164
>
> Log:
> Follow up r35156.
>
> * subversion/libsvn_subr/svn_base64.c
> (base64_from_checksum): Suppress warning of "argument 1 of 'svn_checksum_size'
> discards qualifiers from pointer target type".
>
> Modified:
> trunk/subversion/libsvn_subr/svn_base64.c
>
> Modified: trunk/subversion/libsvn_subr/svn_base64.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/svn_base64.c?pathrev=35164&r1=35163&r2=35164
> ==============================================================================
> --- trunk/subversion/libsvn_subr/svn_base64.c Sun Jan 11 22:54:26 2009 (r35163)
> +++ trunk/subversion/libsvn_subr/svn_base64.c Sun Jan 11 23:08:48 2009 (r35164)
> @@ -381,7 +381,7 @@ svn_base64_decode_string(const svn_strin
> ### This is now only used as a new implementation of svn_base64_from_md5();
> it would probably be safer to revert that to its old implementation. */
> static svn_stringbuf_t *
> -base64_from_checksum(const svn_checksum_t *checksum, apr_pool_t *pool)
> +base64_from_checksum(svn_checksum_t *checksum, apr_pool_t *pool)
> {
> svn_stringbuf_t *checksum_str;
> unsigned char ingroup[3];
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1018435
>
Received on 2009-01-12 09:05:17 CET

This is an archived mail posted to the Subversion Dev mailing list.