[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trunk build broken: Re: svn commit: r34258 - trunk

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 20 Nov 2008 00:26:15 -0800

On Thu, Nov 20, 2008 at 00:04, Jens Seidel <jensseidel_at_users.sf.net> wrote:
> I think you did it wrong.
> CFLAGS="$CFLAGS_KEEP -Wextra-tokens"
> If this test fails CFLAGS_KEEP="$CFLAGS" is executed which sets
> CFLAGS_KEEP to the current value of $CFLAGS which contains -Wextra-tokens.
> This cannot be right, true?

It is right. If the compilation is successful, then I want to keep the
flag that I just tested.

> PS: Don't know why I use "([[]])" (probably I just copied it wrong other
> source). Shouldn't "()" or "([])" be sufficient ([,] are quote characters)?

I've stopped trying to optimize or be precise with my use of quote
characters in m4. It's just all fucked up, and not worth the cycles.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-20 09:26:31 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.