Re: Trunk build broken: Re: svn commit: r34258 - trunk

Hi Greg,

On Wed, Nov 19, 2008 at 11:28:18PM -0800, Greg Stein wrote:
> Thanks, Jens, this helped me come up with a short pattern for flag
> availability detection, which I've now committed in r34280.

(Because of your top posting I removed my sample code, your fault :-()

I think you did it wrong.

CFLAGS_KEEP="$CFLAGS"
AC_LANG_PUSH([C])

CFLAGS="$CFLAGS_KEEP -Wextra-tokens"
AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])

If this test fails CFLAGS_KEEP="$CFLAGS" is executed which sets
CFLAGS_KEEP to the current value of $CFLAGS which contains -Wextra-tokens.

This cannot be right, true?

PS: Don't know why I use "([[]])" (probably I just copied it wrong other
source). Shouldn't "()" or "([])" be sufficient ([,] are quote characters)?

Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-20 09:05:53 CET