Re: Trunk build broken: Re: svn commit: r34258 - trunk

On Thu, Nov 20, 2008 at 12:26:15AM -0800, Greg Stein wrote:
> On Thu, Nov 20, 2008 at 00:04, Jens Seidel <jensseidel_at_users.sf.net> wrote:
> > I think you did it wrong.
> >
> > CFLAGS="$CFLAGS_KEEP -Wextra-tokens"
> > AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])
> >
> > If this test fails CFLAGS_KEEP="$CFLAGS" is executed which sets
> > CFLAGS_KEEP to the current value of $CFLAGS which contains -Wextra-tokens.
> >
> > This cannot be right, true?
>
> It is right. If the compilation is successful, then I want to keep the
> flag that I just tested.

Ah, right. You put code in the success-clause of AC_COMPILE_IFELSE.
 
> > PS: Don't know why I use "([[]])" (probably I just copied it wrong other

s/wrong/from/

> > source). Shouldn't "()" or "([])" be sufficient ([,] are quote characters)?
>
> I've stopped trying to optimize or be precise with my use of quote
> characters in m4. It's just all fucked up, and not worth the cycles.

OK, I hoped you know autoconf better that I so that I can simplify my own
macros ...

Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-20 10:45:39 CET