Stefan Sperling wrote:
> On Fri, Nov 14, 2008 at 06:19:27PM -0800, neels_at_tigris.org wrote:
>> Author: neels
>> Date: Fri Nov 14 18:19:27 2008
>> New Revision: 34214
>>
>> Log:
>> Follow up on r34178, getting rid of compiler warnings.
>>
>> * subversion/include/svn_string.h,
>> * subversion/libsvn_subr/svn_string.c
>> (svn_cstring_join): Make first parameter STRINGS const.
>
> Hmmm... can already released public API be changed like that?
>
> Stefan
Hm, oh.
* neels slaps himself
We don't want a svn_cstring_join2(), do we?
Instead, we could cast explicitly to remove the warnings from gstein's r34178.
But to me the committed fix feels right. svn_cstring_join() doesn't ever
change that parameter. Does making the arg const even cause warnings in
calling code? It doesn't, does it?
~Neels
>
>> Modified:
>> trunk/subversion/include/svn_string.h
>> trunk/subversion/libsvn_subr/svn_string.c
>>
>> Modified: trunk/subversion/include/svn_string.h
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_string.h?pathrev=34214&r1=34213&r2=34214
>> ==============================================================================
>> --- trunk/subversion/include/svn_string.h Fri Nov 14 17:46:41 2008 (r34213)
>> +++ trunk/subversion/include/svn_string.h Fri Nov 14 18:19:27 2008 (r34214)
>> @@ -364,7 +364,7 @@ svn_cstring_count_newlines(const char *m
>> * @since New in 1.2.
>> */
>> char *
>> -svn_cstring_join(apr_array_header_t *strings,
>> +svn_cstring_join(const apr_array_header_t *strings,
>> const char *separator,
>> apr_pool_t *pool);
>>
>>
>> Modified: trunk/subversion/libsvn_subr/svn_string.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/svn_string.c?pathrev=34214&r1=34213&r2=34214
>> ==============================================================================
>> --- trunk/subversion/libsvn_subr/svn_string.c Fri Nov 14 17:46:41 2008 (r34213)
>> +++ trunk/subversion/libsvn_subr/svn_string.c Fri Nov 14 18:19:27 2008 (r34214)
>> @@ -569,7 +569,7 @@ int svn_cstring_count_newlines(const cha
>> }
>>
>> char *
>> -svn_cstring_join(apr_array_header_t *strings,
>> +svn_cstring_join(const apr_array_header_t *strings,
>> const char *separator,
>> apr_pool_t *pool)
>> {
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
>> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>
Received on 2008-11-15 04:41:10 CET