[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3292: 'svnlook diff' regression: doesn't print added dirs

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 30 Oct 2008 22:41:26 +0200 (Jerusalem Standard Time)

Frederic Melot wrote on Tue, 21 Oct 2008 at 16:48 +0200:
> Hello,
>
> here is a patch submission for issue #3292.
>
> Best regards,
> Frédéric Melot
>

Frédéric, thanks for the patch. I have now tried it, and it still
doesn't print the "Added:" headers for added-without-history
directories. Could you look into that?

Also, I'm worried that printing the header right away (as you did) could
lead to other problems: for example, how do you ensure that the header
isn't printed twice (in any case)? That code already isn't the easiest
to follow, and adding prints randomly scattered through won't make it
better.

Thanks,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-30 21:41:48 CET

This is an archived mail posted to the Subversion Dev mailing list.