[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3292: 'svnlook diff' regression: doesn't print added dirs

From: Frederic Melot <frederic.melot_at_lpsc.in2p3.fr>
Date: Fri, 31 Oct 2008 17:57:33 +0100

Hello,

you are totally right. My first concern was only on the "Copied:"
headers for directories and I didn't change anything for "Added:"
directories. I'll do it.

For the second point, I totally agree. But the code of the
'print_diff_tree' function is mainly triggerring 3 cases:
  1) the copied files or folders, which update the string buffer and
doesn't print it.
  2) the files modifications, which update the string buffer and display
it. It is the only code part in which the string buffer is displayed.
This is why diffs on folders never appear.
  3) the meta data modifications, a part which does not make use of the
string buffer and prints directly the results
As the string buffer was already not fully used I didn't use it. If we
want to use it more, this function needs to be more deeper modified. Is
it what you suggested?

Best regards,
Frederic

Daniel Shahaf wrote:
> Frederic Melot wrote on Tue, 21 Oct 2008 at 16:48 +0200:
>
>> Hello,
>>
>> here is a patch submission for issue #3292.
>>
>> Best regards,
>> Frédéric Melot
>>
>>
>
> Frédéric, thanks for the patch. I have now tried it, and it still
> doesn't print the "Added:" headers for added-without-history
> directories. Could you look into that?
>
> Also, I'm worried that printing the header right away (as you did) could
> lead to other problems: for example, how do you ensure that the header
> isn't printed twice (in any case)? That code already isn't the easiest
> to follow, and adding prints randomly scattered through won't make it
> better.
>
> Thanks,
>
> Daniel
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-10-31 17:57:56 CET

This is an archived mail posted to the Subversion Dev mailing list.