[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33528 - in trunk/subversion: include libsvn_delta libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 13 Oct 2008 02:47:27 -0700

On Sun, Oct 12, 2008 at 4:10 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
>...
> def test_txdelta_window
> s = ("a\nb\nc\nd\ne" + "\n" * 100) * 1000
> t = ("a\nb\nX\nd\ne" + "\n" * 100) * 1000
> source = StringIO.new(s)
> target = StringIO.new(t)
> stream = Svn::Delta::TextDeltaStream.new(source, target)
> assert_nil(stream.md5_digest)
> _wrap_assertion do
> stream.each do |window|
> window.ops.each do |op|
> op_size = op.offset + op.length
> case op.action_code
> when Svn::Delta::TXDELTA_SOURCE
> assert_operator(op_size, :<=, window.sview_len)
> when Svn::Delta::TXDELTA_NEW
> assert_operator(op_size, :<=, window.new_data.length)
> when Svn::Delta::TXDELTA_TARGET
> assert_operator(op_size, :<=, window.tview_len)
> else
> flunk
> end
> end
> end
> end
> assert_equal(MD5.new(t).hexdigest, stream.md5_digest) # this assertion fails
> end
>
> Now gives this result:
>
> 1) Failure:
> test_txdelta_window(SvnDeltaTest)
> [D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_delta.rb:47]:
> <"f6fd44565e14c6e44b35292719deb77e"> expected but was
> <"f6fd44565e14c6e44434333433333334">.
>
> line 47 is the marked assertion. So it appears that
> svn_txdelta_md5_digest is returning a different value than it used to.
>
> Not sure if its significant, but I was interested in your opinion
> about if there is a better way to test this or if the problem is the
> changed return value.

Damn. That shouldn't have changed.

Let me take a look...

Thx,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 11:47:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.