[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33604 - trunk/subversion/tests/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 13 Oct 2008 11:29:48 +0100

On Mon, 2008-10-13 at 01:08 -0700, Greg Stein wrote:
> On Sun, Oct 12, 2008 at 6:47 AM, <julianfoad_at_tigris.org> wrote:
> >...
> \> # diff r2 against working copy
> > - diff_repos_wc = [
> > - "Index: A/mucopy\n",
> > - "===================================================================\n",
> > - "--- A/mucopy\t(revision 2)\n",
> > - "+++ A/mucopy\t(working copy)\n",
> > + diff_repos_wc = make_diff_header("A/mucopy", "revision 2", "working copy")
> > + diff_repos_wc += [
>
> (nit)
> All the other functions do +[ on the end of the first line. This one
> breaks that style with the += ...

Adding " + [" would have made the line at least 80 characters long. I
could have moved the last argument onto a new line, though. That would
perhaps have been better. I did check that "+=" is supported in Python
2.2.

Thanks for your attention to detail. I do appreciate it. I think the
same way myself, but just made a different decision in this case.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 12:30:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.