[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33528 - in trunk/subversion: include libsvn_delta libsvn_wc

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Sun, 12 Oct 2008 16:10:22 -0700

Hi Greg,

On Tue, Oct 7, 2008 at 2:16 PM, <gstein_at_tigris.org> wrote:
> Author: gstein
> Date: Tue Oct 7 14:16:03 2008
> New Revision: 33528
> Log:
> Combine the svn_txdelta() and svn_txdelta_send_txstream() functions into a
> single function (since these always come in pairs). In addition, upgrade
> the API style to latest: use svn_checksum, use two pools, and add a cancel
> function.
> Add an example use of it in svn_wc_transmit_text_deltas2(). This function
> has some crazy checksum stuff in it, so we're cleaning it all up through the
> new txdelta routine.
> * subversion/include/svn_delta.h:
> (svn_txdelta_run): new declaration
> * subversion/libsvn_delta/text_delta.c:
> (struct txdelta_baton): toss md5 context, add svn_checksum context.
> add a result pool for the final chcksum.
> (txdelta_next_window): switch to svn_checksum
> (txdelta_md5_digest): get digest from txdelta_baton.checksum->digest
> (svn_txdelta_run): new function
> (svn_txdelta): update initialization of baton.

The ruby bindings started having a test failure after this commit.
Normally I just try to figure out and fix what is going on in the
bindings, but sometimes the bindings tests are sort of a canary in a
coalmine for other issues.

Bottom line this test:

 def test_txdelta_window
    s = ("a\nb\nc\nd\ne" + "\n" * 100) * 1000
    t = ("a\nb\nX\nd\ne" + "\n" * 100) * 1000
    source = StringIO.new(s)
    target = StringIO.new(t)
    stream = Svn::Delta::TextDeltaStream.new(source, target)
    _wrap_assertion do
      stream.each do |window|
        window.ops.each do |op|
          op_size = op.offset + op.length
          case op.action_code
          when Svn::Delta::TXDELTA_SOURCE
            assert_operator(op_size, :<=, window.sview_len)
          when Svn::Delta::TXDELTA_NEW
            assert_operator(op_size, :<=, window.new_data.length)
          when Svn::Delta::TXDELTA_TARGET
            assert_operator(op_size, :<=, window.tview_len)
    assert_equal(MD5.new(t).hexdigest, stream.md5_digest) # this assertion fails

Now gives this result:

  1) Failure:
<"f6fd44565e14c6e44b35292719deb77e"> expected but was

line 47 is the marked assertion. So it appears that
svn_txdelta_md5_digest is returning a different value than it used to.

Not sure if its significant, but I was interested in your opinion
about if there is a better way to test this or if the problem is the
changed return value.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 01:10:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.