[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33582 - trunk/subversion/include

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 10 Oct 2008 01:16:35 -0700

On Thu, Oct 9, 2008 at 9:35 AM, <lgo_at_tigris.org> wrote:
>...
> +++ trunk/subversion/include/svn_path.h Thu Oct 9 09:35:13 2008 (r33582)
> @@ -234,12 +234,8 @@ svn_dirent_is_root(const char *dirent, a
> const char *
> svn_path_canonicalize(const char *path, apr_pool_t *pool);
>
> -/** Return @c TRUE iff path is canonical. Use @a pool for temporary
> - * allocations.
> - *
> - * @note The test for canonicalization is currently defined as
> - * "looks exactly the same as @c svn_path_canonicalize() would make
> - * it look".
> +/** Return @c TRUE iff path is canonical. The @a pool is not used and
> + * may be NULL.

The pool is used in 1.5, right? So if somebody codes to work with 1.5
and passes pool==NULL, then it'll crash.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-10 10:16:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.