[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33583 - in trunk/subversion: libsvn_wc tests/cmdline

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 10 Oct 2008 01:22:26 -0700

On Thu, Oct 9, 2008 at 9:45 AM, <julianfoad_at_tigris.org> wrote:
>...
> +++ trunk/subversion/libsvn_wc/update_editor.c Thu Oct 9 09:45:19 2008 (r33583)
>...
> +tree_has_local_mods(svn_boolean_t *modified,
> + const char *path,
> + svn_wc_adm_access_t *adm_access,
> + apr_pool_t *pool)
> +{
> +
> + static svn_wc_entry_callbacks2_t modcheck_callbacks =
> + { modcheck_found_entry, modcheck_handle_error };

Should be const. (and nit: lose the blank line)

> + modcheck_baton_t modcheck_baton = { NULL, FALSE };
> +
> + modcheck_baton.adm_access = adm_access;

You can put adm_access into the initializer, rather than use a
separate statement.

>...

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-10 10:22:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.