[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33582 - trunk/subversion/include

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 13 Oct 2008 17:37:06 +0200

Greg Stein wrote:
> On Thu, Oct 9, 2008 at 9:35 AM, <lgo_at_tigris.org> wrote:
>> ...
>> +++ trunk/subversion/include/svn_path.h Thu Oct 9 09:35:13 2008 (r33582)
>> @@ -234,12 +234,8 @@ svn_dirent_is_root(const char *dirent, a
>> const char *
>> svn_path_canonicalize(const char *path, apr_pool_t *pool);
>>
>> -/** Return @c TRUE iff path is canonical. Use @a pool for temporary
>> - * allocations.
>> - *
>> - * @note The test for canonicalization is currently defined as
>> - * "looks exactly the same as @c svn_path_canonicalize() would make
>> - * it look".
>> +/** Return @c TRUE iff path is canonical. The @a pool is not used and
>> + * may be NULL.
>
> The pool is used in 1.5, right? So if somebody codes to work with 1.5
> and passes pool==NULL, then it'll crash.

This function is to be deprecated in the near future, but you're right
nonetheless.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 17:36:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.