[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] initialize struct members

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 10 Sep 2008 19:50:41 +0200

Stefan Sperling wrote:
> On Wed, Sep 10, 2008 at 07:19:32PM +0200, Stefan Küng wrote:
>> Hi,
>>
>> Before I commit this, maybe someone likes to first review it:
>> this patch initializes all struct members in the functions
>> svn_wc_conflict_description_create_text() and
>> svn_wc_conflict_description_create_prop().
>> Found this due to crashes in TSVN - it tried to access the merged_file
>> member which had a non-NULL value but pointed to bogus memory.
>
> +1, referencing NULL is bad, but bogus memory is even worse.

Committed in r33017.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Received on 2008-09-10 19:51:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.