Re: [PATCH] initialize struct members

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 10 Sep 2008 19:44:16 +0200

On Wed, Sep 10, 2008 at 07:19:32PM +0200, Stefan Küng wrote:
> Hi,
>
> Before I commit this, maybe someone likes to first review it:
> this patch initializes all struct members in the functions
> svn_wc_conflict_description_create_text() and
> svn_wc_conflict_description_create_prop().
> Found this due to crashes in TSVN - it tried to access the merged_file
> member which had a non-NULL value but pointed to bogus memory.

+1, referencing NULL is bad, but bogus memory is even worse.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-10 19:44:38 CEST

This message: [ Message body ]
Next message: Stefan Küng: "Re: [PATCH] initialize struct members"
Previous message: Stefan Küng: "[PATCH] initialize struct members"
In reply to: Stefan Küng: "[PATCH] initialize struct members"
Next in thread: Stefan Küng: "Re: [PATCH] initialize struct members"
Reply: Stefan Küng: "Re: [PATCH] initialize struct members"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]