Re: [PATCH] initialize struct members

On Wed, Sep 10, 2008 at 07:50:41PM +0200, Stefan Küng wrote:
> Stefan Sperling wrote:
> > On Wed, Sep 10, 2008 at 07:19:32PM +0200, Stefan Küng wrote:
> >> Hi,
> >>
> >> Before I commit this, maybe someone likes to first review it:
> >> this patch initializes all struct members in the functions
> >> svn_wc_conflict_description_create_text() and
> >> svn_wc_conflict_description_create_prop().
> >> Found this due to crashes in TSVN - it tried to access the merged_file
> >> member which had a non-NULL value but pointed to bogus memory.
> >
> > +1, referencing NULL is bad, but bogus memory is even worse.
>
> Committed in r33017.

Thanks. I've tweaked the log message a bit.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-10 20:07:25 CEST