Philipp Marek <philipp_at_marek.priv.at> writes:
>> or the "\b"
> I only found this here: svn_sorts.h
> * If @a and @b intersect then the range with the lower start revision
> * is considered the lesser range. If the ranges' start revisions are
> * equal then the range with the lower end revision is considered the
> * lesser range.
> * @since New in 1.5
> int svn_sort_compare_ranges(const void *a, const void *b);
> But that's wrong - the function above use @c or @a, and @param would be
> possible too.
Oh, those are just typos. It should say "@a a and @a b". (Feel free to
commit an "obvious fix"... :-) )
>> > +#define SVN_PROP_TEXT_TIME SVN_PROP_PREFIX "text-time"
>> Would it be better to call this "SVN_PROP_TEXT_LAST_MODTIME", or
>> something involving the word "MOD", to make it clear exactly what it
>> means? (Same with the value.)
> I thought about that for some time. But
> 1) that constants is used in several files in several projects,
> 2) the documentation above clearly states that it's the "modification"
> 3) there are quite so filesystems which have only a single filetime,
> 4) and versioning an "access" or "inode change" time (which are changed by
> reading resp. eg. chmod) wouldn't make much sense, I think.
> So I took the lazy route, and just kept that as-is.
> If it's important for you, I can still change it. (It's just a fair amount
> of work afterwards.)
Okay, let's keep it as-is. (But why would it be so hard to change
later? Isn't it just a matter of replace-string?)
>> It's fine for you to commit it to trunk, after incorporating any
>> feedback (e.g., Bert's comments, my comments below).
> Thank you; I tried, but got "Authentication failed".
> Either user "pmarek" is revoked for the subversion repository completely,
> or at least limited to the meta-data branch.
> I'm attaching the new patch.
We should solve the 'pmarek' problem. Can you mail
svnadmin_at_svn.collab.net, CC'ing me?
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-07 18:01:25 CEST