On Sunday 07 September 2008 Karl Fogel wrote:
> Philipp Marek <philipp_at_marek.priv.at> writes:
> > I only found this here: svn_sorts.h
> > * If @a and @b intersect then the range with the lower start revision
...
> > But that's wrong - the function above use @c or @a, and @param would be
> > possible too.
>
> Oh, those are just typos. It should say "@a a and @a b". (Feel free to
> commit an "obvious fix"... :-) )
Ok; as soon as I can.
> >> > +#define SVN_PROP_TEXT_TIME SVN_PROP_PREFIX "text-time"
> >>
> >> Would it be better to call this "SVN_PROP_TEXT_LAST_MODTIME", or
> >> something involving the word "MOD", to make it clear exactly what it
> >> means? (Same with the value.)
> >
> > I thought about that for some time. But
> > 1) that constants is used in several files in several projects,
> > 2) the documentation above clearly states that it's the "modification"
> > time,
> > 3) there are quite so filesystems which have only a single filetime,
> > 4) and versioning an "access" or "inode change" time (which are changed
> > by reading resp. eg. chmod) wouldn't make much sense, I think.
> >
> > So I took the lazy route, and just kept that as-is.
> >
> > If it's important for you, I can still change it. (It's just a fair
> > amount of work afterwards.)
>
> Okay, let's keep it as-is. (But why would it be so hard to change
> later? Isn't it just a matter of replace-string?)
Here, yes.
But then the meta-data branch uses that, and the FSVS sources use svn_props.h
too, and only define the property name macros if they are not already; and I
don't know about svntar.
So to do that cleanly at least 2 branches and 2 other software products have
to be changed.
> >> It's fine for you to commit it to trunk, after incorporating any
> >> feedback (e.g., Bert's comments, my comments below).
> >
> > Thank you; I tried, but got "Authentication failed".
...
> We should solve the 'pmarek' problem. Can you mail
> svnadmin_at_svn.collab.net, CC'ing me?
Thank you, I did.
Regards,
Phil
--
Versioning your /etc, /home or even your whole installation?
Try fsvs (fsvs.tigris.org)!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-07 18:52:43 CEST