[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: treeconflicts patch: cosmetic: another missing separator line.

From: Neels Janosch Hofmeyr <neels_at_elego.de>
Date: Fri, 22 Aug 2008 00:56:23 +0200

Hi Daniel!

Daniel Shahaf wrote:
> 1. The patch is broken, your mailer ate the whitespace.

Sorry, my middle-mouse-button pasting must've messed something up.

> 2. Do you really need to send a patch for every missing separator line?
> Remember that not every typo, bad indentation, and strcmp()-that-violates-
> the-recommended-style (when we still had one) deserves a patch post. :)

True. kfogel, on the other hand, committed such a patch... I can't commit,
so I can only post changes or ignore them. I figured you'd just choose to
ignore the post. Should I just ignore these kinds of errors, instead?

> 3. Also, could you use tags properly in your subject lines? To me,
> "treeconflicts patch: cosmetic:" is three long words that I have to
> actually *read* :) (before I decide I'm not interested in the thread
> they're on), while the "[PATCH]" and "tree-conflicts" tags are
> comparatively easier to recognize.

So, a proper subject line for a patch destined for the tree-conflicts branch
should be

  [PATCH] tree-conflicts: foo bar yada

? I previously thought I should keep tree-conflicts branch stuff a little
less loud, as in lower-case non-tagged, to not bother you with it.

Thanks for your feedback!

Neels Hofmeyr -- elego Software Solutions GmbH
Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
phone: +49 30 23458696  mobile: +49 177 2345869  fax: +49 30 23458695
http://www.elegosoft.com | Geschäftsführer: Olaf Wagner | Sitz: Berlin
Handelsreg: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194

Received on 2008-08-22 00:56:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.