1. The patch is broken, your mailer ate the whitespace.
2. Do you really need to send a patch for every missing separator line?
Remember that not every typo, bad indentation, and strcmp()-that-violates-
the-recommended-style (when we still had one) deserves a patch post. :)
3. Also, could you use tags properly in your subject lines? To me,
"treeconflicts patch: cosmetic:" is three long words that I have to
actually *read* :) (before I decide I'm not interested in the thread
they're on), while the "[PATCH]" and "tree-conflicts" tags are
comparatively easier to recognize.
Thanks,
Daniel
Neels Janosch Hofmeyr wrote on Thu, 21 Aug 2008 at 00:10 +0200:
> On the tree-conflicts branch only.
>
>
> [[[
> * subversion/tests/cmdline/merge_tests.py: Add a missing
> separator line.
> ]]]
>
>
> Index: subversion/tests/cmdline/merge_tests.py
> ===================================================================
> --- subversion/tests/cmdline/merge_tests.py (revision 32607)
> +++ subversion/tests/cmdline/merge_tests.py (working copy)
> @@ -12809,6 +12809,7 @@
> os.chdir(saved_cwd)
>
>
> +#----------------------------------------------------------------------
> # Helper for text output.
> def verify_lines(lines, regexes):
> """Return True if each of the given regular expressions matches
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-21 08:44:05 CEST