[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: treeconflicts patch: cosmetic: another missing separator line.

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sat, 23 Aug 2008 14:51:29 -0400

Neels Janosch Hofmeyr <neels_at_elego.de> writes:
>> 2. Do you really need to send a patch for every missing separator line?
>> Remember that not every typo, bad indentation, and strcmp()-that-violates-
>> the-recommended-style (when we still had one) deserves a patch post. :)
> True. kfogel, on the other hand, committed such a patch... I can't commit,
> so I can only post changes or ignore them. I figured you'd just choose to
> ignore the post. Should I just ignore these kinds of errors, instead?

I'd say just ignore these cosmetic problems. They're not worth the
overhead of posting a patch, having someone else review it, commit it,
and follow up. (I committed that one since you posted it, but yeah, in
general I think we don't need to clean out every closet in the code.)

> So, a proper subject line for a patch destined for the tree-conflicts branch
> should be
> [PATCH] tree-conflicts: foo bar yada
> ? I previously thought I should keep tree-conflicts branch stuff a little
> less loud, as in lower-case non-tagged, to not bother you with it.

Any patch should start with "[PATCH]", yes. The above looks good.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-23 20:51:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.